RFR: JDK-8344907 : NullPointerException in Win32ShellFolder2.getSystemIcon when "icon" is null [v3]

Harshitha Onkar honkar at openjdk.org
Wed Jan 8 19:15:02 UTC 2025


On Wed, 8 Jan 2025 12:31:47 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   inverted hIcon condition
>
> src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolder2.java line 1222:
> 
>> 1220:         if (hIcon == 0) {
>> 1221:             return null;
>> 1222:         }
> 
> Suggestion:
> 
>         if (hIcon == 0) {
>             return null;
>         }
> 
> 
> And I'd add a blank line here, too.

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22776#discussion_r1907674346


More information about the client-libs-dev mailing list