RFR: 8347576: Error output in libjsound has non matching format strings [v2]

[Martin Doerr]

On Tue, 14 Jan 2025 10:51:56 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> When enabling the jsound ERROR and TRACE reporting (see src/java.desktop/share/native/libjsound/Configure.h https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/native/libjsound/Configure.h#L32 ), we run into some build warnings as errors  (when building on Linux) because at 2 places the format specifiers do not match the number types .
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Windows fixes

src/java.desktop/windows/native/libjsound/PLATFORM_API_WinOS_MidiIn.cpp line 74:

> 72:     case MIM_DATA:
> 73:         TRACE3("  MIDI_IN_PutMessage: MIM_MOREDATA or MIM_DATA. status=%p  data1=%p  data2=%p\n",
> 74:                (void*)(dwParam1 & 0xFF), (void*)((dwParam1 & 0xFF00)>>8), (void*)((dwParam1 & 0xFF0000)>>16));

I think using "%p" for hex Byte values is a bit strange. Otherwise, good.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23076#discussion_r1914857652