RFR: 8347576: Error output in libjsound has non matching format strings [v4]

[Julian Waters]

On Wed, 15 Jan 2025 12:43:52 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> When enabling the jsound ERROR and TRACE reporting (see src/java.desktop/share/native/libjsound/Configure.h https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/native/libjsound/Configure.h#L32 ), we run into some build warnings as errors  (when building on Linux) because at 2 places the format specifiers do not match the number types .
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
> 
>   change format specifiers at some places in Windows coding

src/java.desktop/windows/native/libjsound/PLATFORM_API_WinOS_MidiIn.cpp line 60:

> 58:     MidiDeviceHandle* handle = (MidiDeviceHandle*) dwInstance;
> 59: 
> 60:     TRACE3("> MIDI_IN_PutMessage, hMidiIn: 0x%" PRIxPTR ", wMsg: %x, dwInstance: 0x%" PRIxPTR "\n", (uintptr_t)hMidiIn, wMsg, (uintptr_t)dwInstance);

It's surprisingly difficult to find the type of HMIDIIN, but the rest of the types here are UINT_PTR and hence %x seems correct

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23076#discussion_r1916702600