RFR: 8344119: CUPSPrinter does not respect PostScript printer definition specification in case of reading ImageableArea values from PPD files [v5]
Prasanta Sadhukhan
psadhukhan at openjdk.org
Fri Jan 17 06:20:40 UTC 2025
On Mon, 13 Jan 2025 11:36:27 GMT, GennadiyKrivoshein <duke at openjdk.org> wrote:
>> **Description:**
>> The PR updates sun.print.CUPSPrinter's behavior in terms of reading media imageable area values according to the PostScript Printer Description File Format Specification.
>> The actual implementation reads X and Y coordinates of the upper right corner of the imageable area as width and height of the imageable area. https://bugs.openjdk.org/browse/JDK-8344119
>>
>> **Updates:**
>> Added subtraction of the X and Y coordinates of the lower left corner to fix the width and height values of the imageable area.
>>
>> **Tests:**
>> Tested with `test/jdk/javax/print/DialogMargins.java` using Brother DCP-T720DW, the test draws a black line along the borders of the imageable area.
>> The test was run with the minimum possible margins.
>> _Before the fix_: the right and bottom lines are not printed (the right and bottom lines are outside the printable area).
>> _After the fix_: all lines are printed.
>
> GennadiyKrivoshein has updated the pull request incrementally with one additional commit since the last revision:
>
> Update test description
test/jdk/javax/print/CUPSPrinterImageableAreaTest.java line 61:
> 59: * @requires (os.family == "linux" | os.family == "mac")
> 60: * @summary CUPSPrinter imageable area
> 61: * @run main/manual CUPSPrinterImageableAreaTest
For new manual test, it's better to use PassFailJFrame framework present in /java/awt/regtesthelpers...You can find several example of it in the repo..
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22110#discussion_r1919616438
More information about the client-libs-dev
mailing list