RFR: 8282862: AwtWindow::SetIconData leaks old icon handles if an exception is detected [v6]

Rajat Mahajan rmahajan at openjdk.org
Fri Jan 17 18:22:57 UTC 2025


> **Issue:** 
> AwtWindow::SetIconData leaks the old icon handles in hOldIcon and hOldIconSm if CreateIconFromRaster raises an exception. Additionally, an exception is checked only after the first call to CreateIconFromRaster.
> 
> **Solution:**
> I have added the exception handling code to take care that the handles are properly destroyed and not leaked.
> 
> **Testing:**
> I have tested the code to make sure there are no regressions caused by this.

Rajat Mahajan has updated the pull request incrementally with one additional commit since the last revision:

  check using not equal to NULL to match the rest of the code in the function

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22932/files
  - new: https://git.openjdk.org/jdk/pull/22932/files/505f804b..2f47a554

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22932&range=05
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22932&range=04-05

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/22932.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22932/head:pull/22932

PR: https://git.openjdk.org/jdk/pull/22932


More information about the client-libs-dev mailing list