RFR: JDK-8347377 : Add validation checks for ICC_Profile header fields [v3]

[Phil Race]

On Sat, 18 Jan 2025 00:01:31 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:

>> test/jdk/java/awt/color/ICC_Profile/ValidateICCHeaderData.java line 39:
>> 
>>> 37: 
>>> 38: public class ValidateICCHeaderData {
>>> 39:     private static ICC_Profile profile;
>> 
>> the change will also affect serialization, the test should check that code path.
>
> @mrserb 
>> the change will also affect serialization, the test should check that code path.
> 
> Please check @prrace response above

What you could do is add a test to prove that deserialisation WILL fail.
You'd need to create a bad profile and save it on JDK 21 - offline so to speak.
Then write a simple test for this release that loads that icc.ser file and verify it is rejected.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23044#discussion_r1920890116