RFR: 8347475: GTK: javax/swing/JColorChooser/Test8152419.java there is no swatches or RGB tab in JColorChooser [v2]

[Alexey Ivanov]

On Mon, 20 Jan 2025 13:07:19 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> There are no tabs available for GTK Look and Feel due to the different ColorChooser UI design. Updated the test to skip testing for GTK L&F.
>
> Abhishek Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   jtreg library tag added

Looks good, except for minor comments.

test/jdk/javax/swing/JColorChooser/Test8152419.java line 30:

> 28: * @summary To Verify JColorChooser tab selection
> 29: * @run main/manual Test8152419
> 30:  */

Suggestion:

/*
 * @test
 * @bug 8152419
 * @library /test/lib
 * @summary To Verify JColorChooser tab selection
 * @run main/manual Test8152419
 */

The formatting of the jtreg tags looks weird.

Usually, the opening `/*` starts in the first column, and the following `*` are aligned to the first one.

test/jdk/javax/swing/JColorChooser/Test8152419.java line 54:

> 52: 
> 53:         // ColorChooser UI design is different for GTK L&F.
> 54:         // There are no tabs available for GTK L&F, skip the testing.

Suggestion:

    public static void main(String args[]) throws Exception {
        // ColorChooser UI design is different for GTK L&F.
        // There are no tabs in GTK L&F, skip the testing.

No blank line at the start of a method; subtle change in comment.

-------------

Marked as reviewed by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23128#pullrequestreview-2563013799
PR Review Comment: https://git.openjdk.org/jdk/pull/23128#discussion_r1922767173
PR Review Comment: https://git.openjdk.org/jdk/pull/23128#discussion_r1922765997