RFR: 8342096: Popup menus that request focus are not shown on Linux with Wayland [v2]

Alexey Ivanov aivanov at openjdk.org
Mon Jan 20 19:53:40 UTC 2025


On Fri, 13 Dec 2024 22:14:31 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> test/jdk/javax/swing/JPopupMenu/NestedFocusablePopupTest.java line 53:
>> 
>>> 51:             //test is valid only when running on Wayland.
>>> 52:             return;
>>> 53:         }
>> 
>> I think it should rather throw `jtreg.SkippedException`.
>> 
>> With [jtreg enhancements](https://github.com/openjdk/jtreg/pull/217) and further reporting enhancements, we'll be able to see if tests aren't actually executed.
>
> Ok, but this test will lose the ability to run standalone with just `java NestedFocusablePopupTest.java`.

It's an inconvenience which can be overcome by compiling the test and `SkippedException` together:


javac -d ./build -cp ./build \
        test/lib/jtreg/SkippedException.java \
        test/jdk/javax/swing/JPopupMenu/NestedFocusablePopupTest.java
java -cp ./build NestedFocusablePopupTest


The advantage is that the test will be reported as skipped if it isn't run when not in Wayland session. It could be not issue as more and more systems use Wayland session by default.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22729#discussion_r1922792552


More information about the client-libs-dev mailing list