RFR: JDK-8347377 : Add validation checks for ICC_Profile header fields [v3]
Harshitha Onkar
honkar at openjdk.org
Tue Jan 21 19:51:36 UTC 2025
On Tue, 14 Jan 2025 17:59:26 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:
>> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>>
>> indentation
>
> test/jdk/java/awt/color/ICC_Profile/ValidateICCHeaderData.java line 39:
>
>> 37:
>> 38: public class ValidateICCHeaderData {
>> 39: private static ICC_Profile profile;
>
> the change will also affect serialization, the test should check that code path.
@mrserb @prrace
Added deserialization test case (as TestCase#15).
invalidSRGB.icc was serialized on JDK 21 and the same .icc profile was deserialized here.
As expected IAE is thrown in this case.
@mrserb All the previous comments have been addressed. Can you please re-review the latest src code and test changes?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23044#discussion_r1924284012
More information about the client-libs-dev
mailing list