RFR: 8340784 : Remove PassFailJFrame constructor with screenshots

[anass baya]

On Wed, 8 Jan 2025 13:14:28 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Remove PassFailJFrame constructor with screenshots since no test is using it
>
> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 473:
> 
>> 471:      * @see Builder Builder
>> 472:      */
>> 473: 
> 
> This blank line is redundant, follow the code style in the file where there's no blank line between the javadoc and the declaration.

Done

> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 510:
> 
>> 508:                         builder.positionWindows
>> 509:                                .positionTestWindows(unmodifiableList(builder.testWindows),
>> 510:                                                     builder.instructionUIHandler));
> 
> Move the documentation to the constructor above.
> 
> https://github.com/openjdk/jdk/blob/26b8b1e71f231d4601737a295dfed1ffd39f9b42/test/jdk/java/awt/regtesthelpers/PassFailJFrame.java#L449-L451
> 
>  Otherwise, you're removing the detailed documentation, which other constructors refer to. You may need to amend some sentences.

thank you for your review

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22873#discussion_r1907379024
PR Review Comment: https://git.openjdk.org/jdk/pull/22873#discussion_r1906140632