RFR: 8282862: AwtWindow::SetIconData leaks old icon handles if an exception is detected [v6]
duke
duke at openjdk.org
Thu Jan 23 20:24:50 UTC 2025
On Fri, 17 Jan 2025 18:22:57 GMT, Rajat Mahajan <rmahajan at openjdk.org> wrote:
>> **Issue:**
>> AwtWindow::SetIconData leaks the old icon handles in hOldIcon and hOldIconSm if CreateIconFromRaster raises an exception. Additionally, an exception is checked only after the first call to CreateIconFromRaster.
>>
>> **Solution:**
>> I have added the exception handling code to take care that the handles are properly destroyed and not leaked.
>>
>> **Testing:**
>> I have tested the code to make sure there are no regressions caused by this.
>
> Rajat Mahajan has updated the pull request incrementally with one additional commit since the last revision:
>
> check using not equal to NULL to match the rest of the code in the function
@rajamah
Your change (at version 2f47a554e93a64869cc560fb89790b3475763557) is now ready to be sponsored by a Committer.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22932#issuecomment-2610941667
More information about the client-libs-dev
mailing list