RFR: 6899304 : java.awt.Toolkit.getScreenInsets(GraphicsConfiguration) returns incorrect values [v2]
anass baya
duke at openjdk.org
Sun Jan 26 00:36:11 UTC 2025
On Fri, 24 Jan 2025 19:13:19 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:
>> anass baya has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update copyright
>
> test/jdk/java/awt/Multiscreen/MultiScreenInsetsTest/MultiScreenInsetsTest.java line 50:
>
>> 48:
>> 49: public static void main(String[] args) throws InterruptedException {
>> 50:
>
> There's no need in a blank right at the start of a method.
I've removed the blank line
Thank you
> test/jdk/java/awt/Multiscreen/MultiScreenInsetsTest/MultiScreenInsetsTest.java line 117:
>
>> 115: System.out.println("Test PASSED!");
>> 116: }
>> 117: static int getMarginForScaleX(GraphicsConfiguration gc) {
>
> I'd add the `private` modifier to both methods as well as a blank line between the methods, especially after the `main` method.
Okey. I've added that
Thank you
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23183#discussion_r1929632692
PR Review Comment: https://git.openjdk.org/jdk/pull/23183#discussion_r1929632608
More information about the client-libs-dev
mailing list