RFR: JDK-8347377 : Add validation checks for ICC_Profile header fields [v3]

Harshitha Onkar honkar at openjdk.org
Sun Jan 26 21:55:46 UTC 2025


On Sat, 25 Jan 2025 04:59:47 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> Since you already mentioned "non-ICC intent", please specify the part of the specification in ICC.1-2022-05 where their use is prohibited.

@mrserb 
The ICC Spec doesn't explicitly say that certain values are prohibited. Although it does not list Non-ICC Intent values under Rendering Intent (pg#23, Table 23) either.

What do you suggest is the best solution here to address the difference in ICC Spec Doc vs LCMS API doc? 

1. Add the missing constants present in LCMS API doc to Java?
2. Or skip validating Rendering Intent? 
3. Since Color Space has few extra constants in LCMS API do we need to address it too?

@prrace Can you please suggest how to address this concern, since the last time we discussed we agreed to follow ICC Spec Doc.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23044#discussion_r1929879842


More information about the client-libs-dev mailing list