RFR: 8345538: Robot.mouseMove doesn't clamp bounds on macOS when trying to move mouse off screen [v6]
Sergey Bylokhov
serb at openjdk.org
Mon Jan 27 10:06:52 UTC 2025
On Fri, 24 Jan 2025 00:25:14 GMT, Alisen Chung <achung at openjdk.org> wrote:
>> Currently on macOS when mouseMove is given an offscreen coordinate to move the mouse to, mouseMove will physically clamp to the edge of the screen, but if you try to grab the mouse location immediately after by using MouseInfo.getPointerInfo().getLocation() you will get the value of the offscreen point.
>>
>> Windows and linux do this clamping and coordinate handling for us, but new distributions may not necessarily handle clamping the same way, so Robot should be checking for clamping rather than delegating it to native.
>>
>> This fix updates shared code to cache the screen bounds and adds a check to not exceed the bounds in mouseMove. The caching is done in the Robot constructor, so if the screen bounds changes the constructor must be called again to update to the new bounds.
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>
> init finX, finY
I would like to clarify one point: if the robot moves the mouse off the screen while the actual mouse pointer is on the screen and immediately presses the mouse button, where will the click occur? on or off the screen?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22781#issuecomment-2615316852
More information about the client-libs-dev
mailing list