RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v2]

Prasanta Sadhukhan psadhukhan at openjdk.org
Wed Jan 29 02:59:04 UTC 2025


On Tue, 28 Jan 2025 13:43:51 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> test/jdk/javax/swing/JMenuItem/TestImageIconWithJRadioButtonMenuItem.java line 51:
>> 
>>> 49:         Verify that for JRadioButtonMenuItem with imageicon,
>>> 50:         radiobutton is been shown alongside the imageicon.
>>> 51:         If radiobutton is shown, test passes else fails.""";
>> 
>> Suggestion:
>> 
>>         One JRadioButtonMenuItem is with imageicon and
>>         another one without imageicon.
>>         Verify that for JRadioButtonMenuItem with imageicon,
>>         radiobutton is been shown alongside the imageicon.
>>         If radiobutton is shown, test passes. Else fails.""";
>> 
>> 
>> Just for consistency, I see theres one capital `i`. I guess you can also just title-case all of the UI components. Ex: ImageIcon and RadioButton.
>
> With it's referred to the type `ImageIcon`, both `i` need to be capitalised; on the other hand, it doesn't make sense for the tester, as they may know nothing about the underlying code and shouldn't know. Just use “image”, it's less confusing than imageicon—is it an image, or is it an icon? Both terms have meaning in UI.

I used "image icon" as it is about icon from image

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23324#discussion_r1933145505


More information about the client-libs-dev mailing list