RFR: 8348865: JButton/bug4796987.java never runs because Windows XP is unavailable

Abhishek Kumar abhiscxk at openjdk.org
Thu Jan 30 07:22:46 UTC 2025


On Tue, 28 Jan 2025 14:51:57 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> The `javax/swing/JButton/4796987/bug4796987.java` test strictly verifies if it's run on Windows XP, for this reason it never runs on modern versions of Windows.
> 
> Since Windows XP is obsolete and visual styles cannot be disabled since Windows 8, I removed the OS version check completely.
> 
> I captured an image of the panel and analyse colors in the image instead of using `Robot.getPixelColor`; I save the image for reference if the test fails.
> 
> The updated test passes in the CI.

test/jdk/javax/swing/JButton/4796987/bug4796987.java line 29:

> 27:  * @key headful
> 28:  * @requires (os.family == "windows")
> 29:  * @summary XP Only: JButton.setBorderPainted() does not work with XP L&F

Summary should be rephrased.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23336#discussion_r1935105461


More information about the client-libs-dev mailing list