RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v2]

Prasanta Sadhukhan psadhukhan at openjdk.org
Thu Jan 30 08:29:47 UTC 2025


On Wed, 29 Jan 2025 02:59:03 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> When JRadioButtonMenuItem is called with imageIcon, then only imageIcon is shown without radiobutton in WIndowsLookAndFeel as there was no provision of drawing the radiobutton alongside icon.
>> If icon is not there, the radiobutton is drawn. Added provision of drawing the radiobutton windows Skin even when imageIcon is present.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   formatting

> @prsadhuk Unable to see the duke image along with RadioButtonMenuItem. Is it correct behaviour?
> 
> ![RadioButtonMenuItem](https://private-user-images.githubusercontent.com/107542245/408042548-fa373784-047f-4af0-bfed-063bc34530b3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzgyMjU1NzcsIm5iZiI6MTczODIyNTI3NywicGF0aCI6Ii8xMDc1NDIyNDUvNDA4MDQyNTQ4LWZhMzczNzg0LTA0N2YtNGFmMC1iZmVkLTA2M2JjMzQ1MzBiMy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMTMwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDEzMFQwODIxMTdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xMDJkMjMyODgwZTY5OGIyYjUxZTU3MDEzMjM2MTY1ZGRjZjk1Yzk2MTIyODIxM2MyYTZhMDg5MGE2ZGRhODc3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.AFbwA8UKoad5R1E58syN-Ap5K6B3Kd920spOiU3Yzww)

did you download the duke file from the PR?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23324#issuecomment-2623831937


More information about the client-libs-dev mailing list