RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v3]

Prasanta Sadhukhan psadhukhan at openjdk.org
Thu Jan 30 09:59:33 UTC 2025


On Thu, 30 Jan 2025 09:40:15 GMT, Abhishek Kumar <abhiscxk at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   image path correction
>
> src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsIconFactory.java line 881:
> 
>> 879:                                 skin.paintSkin(g, x + OFFSET, y + OFFSET, state);
>> 880:                             } else {
>> 881:                                 skin = xp.getSkin(c, part);
> 
> `skin = xp.getSkin(c, part);` can be taken out of if-else block.

ok

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23324#discussion_r1935323239


More information about the client-libs-dev mailing list