RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v4]

[Alexey Ivanov]

On Wed, 29 Jan 2025 02:53:29 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsIconFactory.java line 860:
>> 
>>> 858:                         State state;
>>> 859:                         if (isEnabled(c, null)) {
>>> 860:                             backgroundState = State.NORMAL;
>> 
>> Do you happen to know why `State.BITMAP` was originally here? I tried locating where it originated from, but can't pinpoint exactly why it's either `State.BITMAP` or `State.NORMAL` based on the icon being `null`. Curious only because we're completely eliminating it here and there might be a dependency. However, I haven't encountered any issues when testing yet.
>
> I guess if we can use normal resolution image, then its best to use it than bitmap image which can be flaky..Probably, in earlier days, image icons used to come in bitmap format..

> Do you happen to know why State.BITMAP was originally here?

Perhaps, because of default Windows behaviour: a bitmap menu item fully replaces the menu item text. Yet I can't be sure…

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23324#discussion_r1935448700