RFR: 6899304 : java.awt.Toolkit.getScreenInsets(GraphicsConfiguration) returns incorrect values [v8]

Sergey Bylokhov serb at openjdk.org
Fri Jan 31 01:02:59 UTC 2025


On Wed, 29 Jan 2025 12:25:29 GMT, anass baya <duke at openjdk.org> wrote:

>> Screen number 0 is not always the primary screen, so we’ve removed the code that assumes it is.
>> 
>> We used an existing test and took the following considerations into account for Windows:
>> 
>> - On Windows, undecorated maximized frames are placed over the taskbar.
>> - On Windows, the top-left corner of an undecorated maximized frame may have negative coordinates (x, y).
>> - Consider the fractional part after scaling.
>
> anass baya has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add debug output

test/jdk/java/awt/Multiscreen/MultiScreenInsetsTest/MultiScreenInsetsTest.java line 59:

> 57:         GraphicsDevice[] gds = ge.getScreenDevices();
> 58:         if (gds.length < 2) {
> 59:             System.out.println("It's a multi-screen test... skipping!");

BTW I hope we have a test for insets in a single screen config?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23183#discussion_r1936517419


More information about the client-libs-dev mailing list