RFR: JDK-8347377 : Add validation checks for ICC_Profile header fields [v9]
Harshitha Onkar
honkar at openjdk.org
Fri Jan 31 01:26:50 UTC 2025
On Tue, 21 Jan 2025 20:06:55 GMT, Harshitha Onkar <honkar at openjdk.org> wrote:
>> ICC_Profile.setData(..) does validation of the specified tag contents and throws an exception if it is not valid. But if the tag represents the header, at least some of the validation is lazy, occurring only when the data is used, leading to unexpected exceptions at a later time. The check should be done up-front when the data is set, as in other cases.
>>
>> `verifyHeader(byte[] data)`is called when header data is being updated and the following fields are validated according to the ICC Spec Document. [[1] Pg#19](https://www.color.org/specification/ICC.1-2022-05.pdf).
>>
>> - Profile/Device class
>> - Color Space
>> - Rendering Intent
>> - PCS
>> - Header Size check (ICC Header Size = 128 bytes)
>>
>> These validation checks are added to ICC_Profile.getInstance(..) & ICC_Profile.setData(..) methods.
>>
>> Reference: [1] https://www.color.org/specification/ICC.1-2022-05.pdf
>
> Harshitha Onkar has updated the pull request incrementally with one additional commit since the last revision:
>
> Runtime Exception added
@mrserb Discussed Rendering Intent and other cases with Phil and he thinks all the current validation checks look good as-is and no changes are required. Please refer to his latest comment https://github.com/openjdk/jdk/pull/23044#issuecomment-2619867896
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23044#issuecomment-2626079398
More information about the client-libs-dev
mailing list