RFR: 8361216: Do not fork javac in J2DBench ant build
Eric Caspole
ecaspole at openjdk.org
Thu Jul 3 20:01:47 UTC 2025
On Thu, 3 Jul 2025 19:30:40 GMT, Phil Race <prr at openjdk.org> wrote:
>> Build J2DBench in ant using JAVA_HOME, not using fork to possibly pick a different javac from the PATH.
>
> src/demo/share/java2d/J2DBench/build.xml line 42:
>
>> 40: <property name="resources" location="resources"/>
>> 41:
>> 42: <condition property="source" value="8">
>
> This would be inconsistent with the Make target. It doesn't seem right to update just the ant-based target.
Yes I realized that yesterday, I never actually looked at or used the Makefile before. I will update the Makefile so it least this PR in its own right is consistent, regardless of these other discussion points.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26077#discussion_r2183657821
More information about the client-libs-dev
mailing list