RFR: 8346753: Test javax/swing/JMenuItem/RightLeftOrientation/RightLeftOrientation.java fails on Windows Server 2025 x64 because the icons of RBMenuItem and CBMenuItem are not visible in Nimbus LookAndFeel
Abhishek Kumar
abhiscxk at openjdk.org
Fri Jul 4 08:35:39 UTC 2025
On Fri, 20 Jun 2025 03:09:32 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
> Issue is RadioButtonMenuItem and CheckBoxMenuItem bullet/checkmark icon is not displayed in WindowsL&F when the test is run with NimbusL&F.
> This is because `WindowsIconFactory#VistaMenuItemCheckIcon.paintIcon` called `getLaFIcon()` which returns a empty NimbusIcon which causes no icons to be drawn. This is because the test after setting WIndows L&F of the menuitem reverts back the Windows L&F to Nimbus L&F via `UIManager.setLookAndFeel(save);` call in the test so when frame is made visible, the L&F resets back to Nimbus L&F resulting in null NimbusIcon.
>
> Fix is made to make sure the whole frame is updated to cater to L&F change via `SwingUtilities.updateComponentTreeUI(frame);` call and keep the L&F without reverting back to original L&F..
One more thing I observed is "If we change the order of menu creation" then the icons rendered are different.
For e.g. if the order is
menuBar.add(createMenu("javax.swing.plaf.metal.MetalLookAndFeel",
"Metal"));
menuBar.add(createMenu("com.sun.java.swing.plaf.windows.WindowsLookAndFeel",
"Windows"));
menuBar.add(createMenu("com.sun.java.swing.plaf.motif.MotifLookAndFeel",
"Motif"));
then the icons are

and when Windows L&F is at last pos then rendered icons are

Shouldn't the icons for the L&Fs be same ?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25907#issuecomment-3034978507
More information about the client-libs-dev
mailing list