RFR: 8361216: Do not fork javac in J2DBench ant build
Magnus Ihse Bursie
ihse at openjdk.org
Fri Jul 4 12:33:38 UTC 2025
On Thu, 3 Jul 2025 18:54:12 GMT, Phil Race <prr at openjdk.org> wrote:
> and don't get confused about the ant and make stuff. The JDK build does not and is not expected to build j2dbench
> It is built directly by a developer when they need to run it.
I don't like how there is a separate build system like this. The fact that a resource does not need to be built everytime, but only when it is needed, is not a reason for it to not be built like everything else in the JDK source tree. If J2DBench is needed by developers, then the normal build system should be able to handle building that.
Now this discussion is spinning away a bit from the original PR, but I'd like to better understand what purpose the remaining demos serve, and if they are really located in the right place.
>From what I can see we have these demos:
* java2d/J2DBench
* jfc/CodePointIM
* jfc/FileChooserDemo
* jfc/Font2DTest
* jfc/J2Ddemo
* jfc/Metalworks
* jfc/Notepad
* jfc/SampleTree
* jfc/Stylepad
* jfc/SwingSet2
* jfc/TableExample
* jfc/TransparentRuler
All the jfc demos are built by the normal JDK build system. But some of them also have additional build.xml files, and J2DBench also have a separate Makefile.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/26077#issuecomment-3036052948
More information about the client-libs-dev
mailing list