RFR: 8346753: Test javax/swing/JMenuItem/RightLeftOrientation/RightLeftOrientation.java fails on Windows Server 2025 x64 because the icons of RBMenuItem and CBMenuItem are not visible in Nimbus LookAndFeel [v3]

Abhishek Kumar abhiscxk at openjdk.org
Mon Jul 7 05:10:40 UTC 2025


On Mon, 7 Jul 2025 05:05:01 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> Issue is RadioButtonMenuItem and CheckBoxMenuItem bullet/checkmark icon is not displayed in WindowsL&F when the test is run with NimbusL&F.
>> This is because `WindowsIconFactory#VistaMenuItemCheckIcon.paintIcon` called `getLaFIcon()` which returns a empty NimbusIcon which causes no icons to be drawn. This is because the test after setting WIndows L&F of the menuitem reverts back the Windows L&F to Nimbus L&F via `UIManager.setLookAndFeel(save);` call in the test so when frame is made visible, the L&F resets back to Nimbus L&F resulting in null NimbusIcon.
>> 
>> Fix is made to make sure the whole frame is updated to cater to L&F change via `SwingUtilities.updateComponentTreeUI(frame);` call and keep the L&F without reverting back to original L&F..
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove title

test/jdk/javax/swing/JMenuItem/RightLeftOrientation.java line 127:

> 125: 
> 126:         frame.setJMenuBar(menuBar);
> 127:         frame.pack();

Test frame title is not visible when `frame.pack` is used
Suggestion:

        frame.setSize(250, 100);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25907#discussion_r2188979537


More information about the client-libs-dev mailing list