RFR: 8361067: Test ExtraButtonDrag.java requires frame.dispose in finally block [v2]

[Prasanta Sadhukhan]

On Tue, 1 Jul 2025 10:12:29 GMT, Ravi Gupta <rgupta at openjdk.org> wrote:

>> Test test/jdk/java/awt/Mouse/MouseModifiersUnitTest/ExtraButtonDrag.java left debris on system whenever fails its required frame.dispose() in finally block.
>> 
>> 
>>  finally {
>>             EventQueue.invokeAndWait(ExtraButtonDrag::disposeFrame);
>>         }
>>     public static void disposeFrame() {
>>         if (frame != null) {
>>             frame.dispose();
>>             frame = null;
>>         }
>>     }
>
> Ravi Gupta has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8361067: EventQueue.invokeAndWait used

test/jdk/java/awt/Mouse/MouseModifiersUnitTest/ExtraButtonDrag.java line 54:

> 52:     }
> 53: 
> 54:     public static void main(String []s) throws InvocationTargetException, InterruptedException, AWTException{

Better to have "throws Exception" and expand wildcard imports.
Remove author tag

test/jdk/java/awt/Mouse/MouseModifiersUnitTest/ExtraButtonDrag.java line 55:

> 53: 
> 54:     public static void main(String []s) throws InvocationTargetException, InterruptedException, AWTException{
> 55:         frame = new ExtraButtonDrag();

please use robot.waitForIdle before robot.delay after frame is set visible..

test/jdk/java/awt/Mouse/MouseModifiersUnitTest/ExtraButtonDrag.java line 127:

> 125:             }
> 126:         }
> 127:         finally {

move finally to previous line as per coding guideline.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26043#discussion_r2189079934
PR Review Comment: https://git.openjdk.org/jdk/pull/26043#discussion_r2189086627
PR Review Comment: https://git.openjdk.org/jdk/pull/26043#discussion_r2189081285