RFR: 8358468: Enhance code consistency: java.desktop/macos [v2]
Sergey Bylokhov
serb at openjdk.org
Tue Jul 15 02:54:42 UTC 2025
On Mon, 14 Jul 2025 20:47:00 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:
>> Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>>
>> - Merge branch 'openjdk:master' into over_macos
>> - Fix java/awt/dnd/BadSerializationTest/BadSerializationTest.java test
>> - restore formatting
>> - final in java.desktop/macos
>> - override in java.desktop/macos
>
> src/java.desktop/macosx/classes/com/apple/laf/AquaFonts.java line 38:
>
>> 36:
>> 37: @SuppressWarnings("serial") // JDK implementation class
>> 38: public final class AquaFonts {
>
> This final class has two protected methods:
>
>
> protected static FontUIResource getMiniControlTextFont() {
> protected static FontUIResource getSmallControlTextFont() {
>
>
> There may be more, but I suppose this can be handled as a separate issue.
Yes, it intentionally includes only this change, which might already be too large to review. However, there will be more follow-ups.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25607#discussion_r2206172387
More information about the client-libs-dev
mailing list