RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v33]
Phil Race
prr at openjdk.org
Tue Jul 15 19:34:48 UTC 2025
On Mon, 14 Jul 2025 05:16:11 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
> > Shouldn't Windows 10 do it the new way too ?
>
> I didn't intentionally change the design for Windows 10 as that was the behaviour which was in existence (even though by "accident" as we learnt) for so long our JDK code for Windows L&F is in existence, and some user might see the change (if we make Windows 11 and 10 same) and find it abrupt and not in sync to whatever they were seeing and "used to" till now
>
> Also, there was no issue raised for Windows 10 about this behaviour so I believe it was same with native app. Also, Windows 10 I believe is in its last leg and probable EOL in few months so thought of not changing the behaviour at this last moment. Finally, any change to Windows 10 design will require extensive testing and I didn't have any Windows10 system so would have to rely on others and it would have been hard to replicate and fix if reported by others.
No issue was raised because no one knew any better. Now we know.
I realise that it is a little more work for you but I think it is the right thing to do and will make the code easier to maintain and test, not harder.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23324#discussion_r2208482989
More information about the client-libs-dev
mailing list