RFR: 8362291: [macOS] Remove finalize method in CGraphicsEnvironment.java [v2]

Phil Race prr at openjdk.org
Wed Jul 16 20:57:44 UTC 2025


On Tue, 15 Jul 2025 22:40:02 GMT, Phil Race <prr at openjdk.org> wrote:

>> src/java.desktop/macosx/classes/sun/awt/CGraphicsEnvironment.java line 154:
>> 
>>> 152: 
>>> 153:         public synchronized void dispose() {
>>> 154:             if (displayReconfigContext != 0L) {
>> 
>> can it be 0 here? it seems we never register 0 pointer, and we have a guard in native to be safe.
>
> and is there any harm in the check ?

I removed the check

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26332#discussion_r2211585561


More information about the client-libs-dev mailing list