RFR: 8362289: [macOS] Remove finalize method in JRSUIControls.java [v2]

Phil Race prr at openjdk.org
Wed Jul 16 21:00:43 UTC 2025


On Wed, 16 Jul 2025 00:11:03 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> I am not *expecting* it to be called twice. I'm just saying that with this check it would be safe if it were.
>> Not sure I even need synchronization here. Only the Disposer will have a reference.
>> So I could remove synchronized, remove the != 0 check  ... but I don't see a problem either way.
>
> That would be great if we could drop all unneeded code.

I removed the != 0 and the synchronized modifier

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26331#discussion_r2211591459


More information about the client-libs-dev mailing list