RFR: 8362289: [macOS] Remove finalize method in JRSUIControls.java [v3]

Phil Race prr at openjdk.org
Wed Jul 16 22:45:22 UTC 2025


On Wed, 16 Jul 2025 22:07:09 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Phil Race has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
>> 
>>  - Merge branch 'master' into jrsuicontrols
>>  - 8362289
>>  - 8362289
>>  - 8362289
>
> src/java.desktop/macosx/classes/apple/laf/JRSUIControl.java line 134:
> 
>> 132:             } catch (Throwable t) {
>> 133:             }
>> 134:             cfDictionaryPtr = 0;
> 
> cfDictionaryPtr = 0 seems is not needed as well we do not reset pointers in other classes -> then we can mark cfDictionaryPtr as final.

it can already be made final in the main class but I can do it as well in the DisposerRecord

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26331#discussion_r2211745825


More information about the client-libs-dev mailing list