RFR: 8159055: ImageIcon.setImage can't handle null parameter [v15]

[Prasanta Sadhukhan]

On Tue, 22 Jul 2025 17:52:22 GMT, Phil Race <prr at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Document NPE behaviour and update test and add class-level statement
>>  - Document NPE behaviour and update test and add class-level statement
>
> src/java.desktop/share/classes/javax/swing/ImageIcon.java line 68:
> 
>> 66:  * no exceptions will be thrown but the image will be 'effectively' null,
>> 67:  * as it will have no dimensions and never be drawn, and
>> 68:  * getImageLoadStatus() will report ERRORED.
> 
> ERRORED should be a link - I presume to MediaTracker.ERRORED

Fixed

> src/java.desktop/share/classes/javax/swing/ImageIcon.java line 228:
> 
>> 226:      * If the image has a "comment" property that is a string,
>> 227:      * then the string is used as the description of this icon.
>> 228:      * Passing {@code null} Image will result in {@code NullPointerException}.
> 
> "Passing" -> "Passing a"

fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25767#discussion_r2224275974
PR Review Comment: https://git.openjdk.org/jdk/pull/25767#discussion_r2224276278