RFR: 8159055: ImageIcon.setImage can't handle null parameter [v19]

Prasanta Sadhukhan psadhukhan at openjdk.org
Sun Jul 27 07:02:16 UTC 2025


On Fri, 25 Jul 2025 11:37:45 GMT, ExE Boss <duke at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use code tag and update test
>
> test/jdk/javax/swing/ImageIcon/ImageIconTest.java line 42:
> 
>> 40: 
>> 41:     static enum ArgType { FILE, URL, BYTEARRAY, IMAGE };
>> 42:     static enum ArgVal { NULL, INVALIDDATA };
> 
> Maybe name this `INVALID_DATA`:
> Suggestion:
> 
>     static enum ArgVal { NULL, INVALID_DATA };

ok

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25767#discussion_r2233795108


More information about the client-libs-dev mailing list