RFR: 8348760: RadioButton is not shown if JRadioButtonMenuItem is rendered with ImageIcon in WindowsLookAndFeel [v36]

Prasanta Sadhukhan psadhukhan at openjdk.org
Sun Jul 27 07:16:02 UTC 2025


On Thu, 17 Jul 2025 02:18:16 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> When JRadioButtonMenuItem is called with imageIcon, then only imageIcon is shown without radiobutton in WIndowsLookAndFeel as there was no provision of drawing the radiobutton alongside icon.
>> If icon is not there, the radiobutton is drawn. Added provision of drawing the radiobutton windows Skin even when imageIcon is present.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove Windows version check

> Ok, on Windows 10 it kind of works but there's some confusion about the radio button's check mark size. Here: <img alt="w10latest" width="359" height="350" src="https://private-user-images.githubusercontent.com/69642324/471031541-f52007ea-6aaf-4a08-b98b-ca8deabdb424.PNG?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTM2MDA0MTEsIm5iZiI6MTc1MzYwMDExMSwicGF0aCI6Ii82OTY0MjMyNC80NzEwMzE1NDEtZjUyMDA3ZWEtNmFhZi00YTA4LWI5OGItY2E4ZGVhYmRiNDI0LlBORz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA3MjclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNzI3VDA3MDgzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU5NDE3OTE0NDNkZTNlZjhiM2M2MWNmMDhiNzMwNGE4ODk4MzNmMzdmZTcwZjg4NTFkNThjZjJmZjRhZTI5MmMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.jcKFjs2YyjYvV-oqFfd_wsNWcaJ15tu1jPo_wOZa3mw">

Thanks for your testing on Windows 10.
Did you update your Windows 10 to latest version? 
I guess it was told by Microsoft as reported by Phil that "the visual "cue" we've relied on for in Windows 10 was just an accident of some theming that is now gone. 

so I thought the skin background blue effect would have been replaced in the "new theme"

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23324#issuecomment-3124142950


More information about the client-libs-dev mailing list