RFR: 8364230: javax/swing/text/StringContent can be migrated away from using finalize

Mikhail Yankelevich myankelevich at openjdk.org
Tue Jul 29 10:40:56 UTC 2025


On Mon, 28 Jul 2025 22:38:03 GMT, Phil Race <prr at openjdk.org> wrote:

> Convert StringContent's Position usage tracking to use a WeakReference
> 
> The test that is added only implicitly tests this but I added it because of a complete lack of any test for this code.

Could you please upfat

src/java.desktop/share/classes/javax/swing/text/StringContent.java line 27:

> 25: package javax.swing.text;
> 26: 
> 27: import java.util.Vector;

Could you please update copyright in this file?

test/jdk/javax/swing/text/AbstractDocument/StringContentPositionTest.java line 29:

> 27: 
> 28: /*
> 29:  * @test

Could you please add `@bug` with bug id here

-------------

PR Review: https://git.openjdk.org/jdk/pull/26519#pullrequestreview-3066804830
PR Review Comment: https://git.openjdk.org/jdk/pull/26519#discussion_r2239345313
PR Review Comment: https://git.openjdk.org/jdk/pull/26519#discussion_r2239349764


More information about the client-libs-dev mailing list