RFR: 4938801: The popup does not go when the component is removed [v7]

[Prasanta Sadhukhan]

On Wed, 30 Jul 2025 13:02:18 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Serialization fix
>
> src/java.desktop/share/classes/javax/swing/JPopupMenu.java line 934:
> 
>> 932:     }
>> 933: 
>> 934:     private class Listener implements PropertyChangeListener,Serializable {
> 
> Suggestion:
> 
>     private final class AncestorListener implements PropertyChangeListener, Serializable {
> 
> Be more specific. Make the class `final` explicitly; it's not meant to be extended. Put a space after the comma.

ok

> src/java.desktop/share/classes/javax/swing/JPopupMenu.java line 935:
> 
>> 933: 
>> 934:     private class Listener implements PropertyChangeListener,Serializable {
>> 935:         public void propertyChange(PropertyChangeEvent e) {
> 
> Add `@Override` annotation.

ok

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26407#discussion_r2244202043
PR Review Comment: https://git.openjdk.org/jdk/pull/26407#discussion_r2244202169