RFR: 8251928: [macos] the printer DPI always be 72, cause some content lost when print out

Prasanta Sadhukhan psadhukhan at openjdk.org
Tue Jun 3 07:00:58 UTC 2025


On Wed, 28 May 2025 10:29:17 GMT, GennadiyKrivoshein <duke at openjdk.org> wrote:

> The fix for the https://bugs.openjdk.org/browse/JDK-8251928.
> 
> **Description**.
> This PR contains changes to be able to print with DPI higher than 72 on macOS, set default CPrinterJob DPI is 300 like in the PSPrinterJob.
> 
> As described in the macOS drawing guide, the following steps are required to draw with high DPI (https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/CocoaDrawingGuide/Transforms/Transforms.html#//apple_ref/doc/uid/TP40003290-CH204-BCICIJAJ):
> 1. Convert the user-space point, size, or rectangle value to device space coordinates;
> 2. Normalize the value in device space so that it is aligned to the appropriate pixel boundary;
> 3. Convert the normalized value back to user space;
> 4. Draw your content using the adjusted value. 
>     
> The 1-st step is now implemented in the CPrinterJob, a Graphics provided to the print method adjusted to a printer's DPI.
> The 2-nd step is a drawing process in the java code (without changes).
> The 3-rd step is now implemented in the PrinterView.m, the drawing scaled back to the 72 DPI.
> The 4-th step is a drawing process in the native code (without changes).
> 
> **Tests**.
> I run all tests from javax.print package and there is no any regression.
> New test covers macOS and Linux only because we know its default DPI - 300.

src/java.desktop/macosx/classes/sun/lwawt/macosx/CPrinterJob.java line 742:

> 740:     private Rectangle2D getPageFormatArea(PageFormat page, double scaleX, double scaleY) {
> 741:         Rectangle2D.Double pageFormatArea;
> 742:         if (scaleX != 1 && scaleY != 1) {

BTW, Do we need this check as if scaleX=scaleY=1 then also no issue in doing multiplying with 1 ie scaleX and scaleY and if one of them is not 1 then we need to multiply anyway..so it seems this check is not needed?!!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25489#discussion_r2122900262


More information about the client-libs-dev mailing list