RFR: 8357799: Improve instructions for JFileChooser/HTMLFileName.java [v2]

Tejesh R tr at openjdk.org
Tue Jun 3 07:11:02 UTC 2025


On Sun, 1 Jun 2025 19:48:35 GMT, Phil Race <prr at openjdk.org> wrote:

>> Alexey Ivanov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Correct the title of the test frames
>
> test/jdk/javax/swing/JFileChooser/HTMLFileName.java line 128:
> 
>> 126:         jfc.setControlButtonsAreShown(false);
>> 127: 
>> 128:         JFrame frame = new JFrame((!htmlEnabled) ? "HTML enabled" : "HTML disabled");
> 
> I think this stems from a conflict in the name of the property (html.disable) and the variable (htmlEnabled)
> I suggest to rename the variable to htmlDisabled and re-organise the constructor line to
> JFrame frame = new JFrame((htmlDisabled) ? "HTML disabled" : "HTML enabled");

Yes, I agree to this point.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25455#discussion_r2122922480


More information about the client-libs-dev mailing list