RFR: 8356803: Test TextLayout/TestControls fails on windows & linux: line and paragraph separator show non-zero advance
Daniel Gredler
dgredler at openjdk.org
Tue Jun 3 09:40:53 UTC 2025
On Fri, 30 May 2025 23:40:22 GMT, Daniel Gredler <dgredler at openjdk.org> wrote:
> Per discussion in JBS, adds the following chars to the list of ignorable whitespace chars: U+000B (Vertical Tab), U+000C (Form Feed), U+0085 (Next Line), U+2028 (Line Separator), U+2029 (Paragraph Separator).
>
> Adds the necessary testing in pre-existing automated test class `test/jdk/java/awt/font/TextLayout/FormatCharAdvanceTest.java`.
>
> Removes now-unnecessary manual test `test/jdk/java/awt/font/TextLayout/TestControls.java`.
>
> The `test/jdk/java/awt/font`, `test/jdk/java/awt/print` and `test/jdk/java/awt/Graphics2D/DrawString` tests all pass for me locally on Windows, Linux and macOS.
@aivanov-jdk Let me know if there are any concerns on your end. Otherwise, I plan to mark as ready for integration later today. As @honkar-jdk mentioned, the automated test is checking much more than the manual test was (and won't bitrot as easily), so I don't think there's a reason to keep the manual test around.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25560#issuecomment-2934383570
More information about the client-libs-dev
mailing list