RFR: 8345538: Robot.mouseMove doesn't clamp bounds on macOS when trying to move mouse off screen [v14]
Phil Race
prr at openjdk.org
Tue Jun 3 17:25:55 UTC 2025
On Tue, 27 May 2025 17:35:17 GMT, Alisen Chung <achung at openjdk.org> wrote:
>> Currently on macOS when mouseMove is given an offscreen coordinate to move the mouse to, mouseMove will physically clamp to the edge of the screen, but if you try to grab the mouse location immediately after by using MouseInfo.getPointerInfo().getLocation() you will get the value of the offscreen point.
>>
>> Windows and linux do this clamping and coordinate handling for us, but new distributions may not necessarily handle clamping the same way, so Robot should be checking for clamping rather than delegating it to native.
>>
>> This fix updates shared code to cache the screen bounds and adds a check to not exceed the bounds in mouseMove. The caching is done in the Robot constructor, so if the screen bounds changes the constructor must be called again to update to the new bounds.
>
> Alisen Chung has updated the pull request incrementally with two additional commits since the last revision:
>
> - add logging to test
> - test require macos, spacing in crobot
I applied the current fix to an up-to-date repo and ran all our automated tests and all looks good. I think it is time to push this.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22781#issuecomment-2936398556
More information about the client-libs-dev
mailing list