RFR: 8353950: Clipboard interaction on Windows is unstable [v5]
Matthias Bläsing
mblaesing at openjdk.org
Tue Jun 3 20:35:37 UTC 2025
On Mon, 2 Jun 2025 16:19:25 GMT, Alisen Chung <achung at openjdk.org> wrote:
>> Matthias Bläsing has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Address review comments:
>>
>> - reduce log level in WClipboard#handleContentsChanged to DEBUG, so that
>> in normal operation it will not be visible
>> - restore comment on WClipboard#closeClipboard
>> - adjust comment on WClipboard#openClipboard
>> - Ensure ConcurrentClipboardAccessTest shutsdown on its own when not
>> run in an environment with an external timeout handling.
>> - Added finishing message to ConcurrentClipboardAccessTest, so that
>> correct termination can be determined visually if run manually
>
> src/java.desktop/windows/classes/sun/awt/windows/WClipboard.java line 113:
>
>> 111: @Override
>> 112: public native void openClipboard(SunClipboard newOwner) throws IllegalStateException;
>> 113: /**
>
> was this comment accidentally deleted?
Restored the comment and adjusted the comment on `openClipboard` to better address the required calling sequence.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24614#discussion_r2124869380
More information about the client-libs-dev
mailing list