RFR: 8352149: Test java/awt/Frame/MultiScreenTest.java generates too many frames on Linux [v8]

Khalid Boulanouare duke at openjdk.org
Thu Jun 5 08:20:55 UTC 2025


On Wed, 4 Jun 2025 19:06:57 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Khalid Boulanouare has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removes unnecessary lines and keep consistent code format
>
> test/jdk/java/awt/Frame/MultiScreenTest.java line 91:
> 
>> 89:                 .columns(40)
>> 90:                 .testUI(obj::init)
>> 91:                 .build()
> 
> Suggestion:
> 
>                 .testUI(obj::init)
>                 .positionTestUI(MultiScreenTest::positionTestWindows)
>                 .build()
> 
> 
> where
> 
> 
>     private static void positionTestWindows(List<Window> testWindows,
>                                             PassFailJFrame.InstructionUI instructionUI) {
>         // Do nothing - the location of each window is set when they're created
>     }
> 
> This allows keeping both created frames / windows `Screen#` and `DitherTest GC#` together for each screen.
> 
> Perhaps, such a null layout should be added as library method into [`WindowLayouts.java`](https://github.com/openjdk/jdk/blob/master/test/jdk/java/awt/regtesthelpers/WindowLayouts.java).

Method created and code updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24752#discussion_r2128241063


More information about the client-libs-dev mailing list