RFR: 8352149: Test java/awt/Frame/MultiScreenTest.java generates too many frames on Linux [v10]

Alexey Ivanov aivanov at openjdk.org
Thu Jun 5 17:08:54 UTC 2025


On Thu, 5 Jun 2025 09:35:16 GMT, Khalid Boulanouare <duke at openjdk.org> wrote:

>> Fixes issue in which the test fails when run on multi-screen machine.
>> 
>> Tested on Ubuntu 24.04, MacOS 15 and Windows 11
>> 
>> JTREG
>> 
>> runner starting test: java/awt/Frame/MultiScreenTest.java
>> runner finished test: java/awt/Frame/MultiScreenTest.java
>> Passed. Execution successful
>
> Khalid Boulanouare has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Nests classes inside test class
>  - Cleans up code

Just minor comments.

Update the subject of the PR to align with the JBS subject.

test/jdk/java/awt/Frame/MultiScreenTest.java line 134:

> 132:         return list;
> 133:     }
> 134:     static class GCCanvas extends Canvas {

Leave a blank line between the method and the following class. You may even have two blank lines here.

test/jdk/java/awt/Frame/MultiScreenTest.java line 496:

> 494:         }
> 495:     }
> 496: }

Please keep line break as the last character in the file.

-------------

Changes requested by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24752#pullrequestreview-2901120947
PR Review Comment: https://git.openjdk.org/jdk/pull/24752#discussion_r2129372187
PR Review Comment: https://git.openjdk.org/jdk/pull/24752#discussion_r2129330758


More information about the client-libs-dev mailing list