RFR: 8355904: Use variadic macros for J2dTrace [v7]

Nikita Gubarkov ngubarkov at openjdk.org
Fri Jun 6 08:36:40 UTC 2025


> J2dTrace macros have multiple overloads specifying number of arguments, making it less convent to change number of arguments. There were cases when existing macros were not enough and people had to add new variants with even more arguments. We could simply use variadic macros instead.
> 
> Also, currently those macros expand to a { code block }, which doesn't require a semicolon at the end, so it can sometimes be missed, leading to an inconsistent code style. We could expand it directly to the function, forcing user to insert a semicolon after that, in a function-like style.

Nikita Gubarkov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:

 - Merge remote-tracking branch 'origin/master' into JDK-8355904
 - Update D3DShaderGen.c
 - fixup! 8355904: Use variadic macros for J2dTrace
 - fixup! 8355904: Use variadic macros for J2dTrace
 - fixup! 8355904: Use variadic macros for J2dTrace
 - Apply suggestions from code review
   
   Co-authored-by: Alexey Ivanov <alexey.ivanov at oracle.com>
 - fixup! 8355904: Use variadic macros for J2dTrace
 - 8355904: Use variadic macros for J2dTrace

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/24949/files
  - new: https://git.openjdk.org/jdk/pull/24949/files/41ce75f2..a4f9d118

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=24949&range=06
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=24949&range=05-06

  Stats: 202333 lines in 3676 files changed: 124546 ins; 52157 del; 25630 mod
  Patch: https://git.openjdk.org/jdk/pull/24949.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/24949/head:pull/24949

PR: https://git.openjdk.org/jdk/pull/24949


More information about the client-libs-dev mailing list