RFR: 8354646: java.awt.TextField allows to identify the spaces in a password when double clicked at the starting and end of the text [v13]
Jeremy Wood
duke at openjdk.org
Fri Jun 6 21:50:44 UTC 2025
> Make sure AquaTextPasswordFieldUI can't use selectWordAction.
>
> The core problem here was we could call selectWordAction in the Aqua LAF on a JPasswordField. This problem was already solved in the BasicPasswordFieldUI and SynthPasswordFieldUI, but the AquaTextPasswordFieldUI does NOT extend the BasicPasswordFieldUI, so it wasn't inheriting this solution.
>
> So the problem is partially about multiple inheritance.
>
> My first response at solving the problem is just to move the existing solution to the parent BasicTextUI class and use an instanceof to make sure it is only applied to JPasswordFields.
>
> There may be many different philosophies/recommendations on how to resolve this; I'm open to suggestions.
Jeremy Wood has updated the pull request incrementally with five additional commits since the last revision:
- 8354646: add missing import
- 8354646: fixing compiler error typo
- 8354646: fail test with exception for unexpected UI
This is in response to:
https://github.com/openjdk/jdk/pull/25443#discussion_r2131930548
- 8354646: remove selectWordAction whether or not selectLineAction exists
This is in response to:
https://github.com/openjdk/jdk/pull/25443#discussion_r2131922909
- 8354646: change "create" to "edit" in comment
This is in response to:
https://github.com/openjdk/jdk/pull/25443#discussion_r2131918285
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/25443/files
- new: https://git.openjdk.org/jdk/pull/25443/files/c4c47d89..7aff3231
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=25443&range=12
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=25443&range=11-12
Stats: 8 lines in 2 files changed: 2 ins; 3 del; 3 mod
Patch: https://git.openjdk.org/jdk/pull/25443.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/25443/head:pull/25443
PR: https://git.openjdk.org/jdk/pull/25443
More information about the client-libs-dev
mailing list