RFR: 8354646: java.awt.TextField allows to identify the spaces in a password when double clicked at the starting and end of the text [v16]

[Alexey Ivanov]

On Mon, 9 Jun 2025 21:41:12 GMT, Jeremy Wood <duke at openjdk.org> wrote:

>> Make sure AquaTextPasswordFieldUI can't use selectWordAction.
>> 
>> The core problem here was we could call selectWordAction in the Aqua LAF on a JPasswordField. This problem was already solved in the BasicPasswordFieldUI . The same solution was copied and pasted into the SynthPasswordFieldUI . But the AquaTextPasswordFieldUI does NOT extend either class with the solution.
>> 
>> So the problem is partially about multiple inheritance.
>> 
>> My first response at solving the problem is just to move the existing solution to the parent BasicTextUI class and use an `instanceof` to make sure it is only applied to JPasswordFields. This should benefit all the PasswordFieldUI's (that I know about).
>> 
>> There may be many different philosophies/recommendations on how to resolve this; I'm open to suggestions.
>
> Jeremy Wood has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8354646: moving test file back to basic package
>   
>   This is in response to:
>   https://github.com/openjdk/jdk/pull/25443#discussion_r2136478249
>   https://github.com/openjdk/jdk/pull/25443#issuecomment-2956995265

test/jdk/javax/swing/plaf/basic/BasicPasswordFieldUI/PasswordSelectionWordTest.java line 1:

> 1: /*

I think the test belongs now *under `BasicTextUI`*, although it tests the behaviour related to `JPasswordField` and `PasswordFieldUI`, but the code that handles password fields is in `BasicTextUI`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25443#discussion_r2137904314