RFR: 8150564: Migrate useful ExtendedRobot methods into awt.Robot [v19]
Harshitha Onkar
honkar at openjdk.org
Wed Jun 11 17:52:49 UTC 2025
On Tue, 10 Jun 2025 21:47:26 GMT, Alisen Chung <achung at openjdk.org> wrote:
>> Some useful methods in ExtendedRobot should be migrated into Robot itself so that ExtendedRobot can be removed in the future. The tests using ExtendedRobot for these migrated methods are changed to use only Robot (removing unnecessary building of ExtendedRobot).
>
> Alisen Chung has updated the pull request incrementally with one additional commit since the last revision:
>
> synchronized for type(char)
I see couple of tests that use ExtendedRobot which can be changed to use Robot. Can you double check these tests.
java/awt/Frame/DisposeParentGC/DisposeParentGC.java
java/awt/List/SetBackgroundTest/SetBackgroundTest.java
java/awt/Modal/ToBack/ToBackFDFTest.java
test/jdk/lib/client/ExtendedRobot.java line 237:
> 235: public void glide(Point src, Point dest) {
> 236: glide(src.x, src.y, dest.x, dest.y, DEFAULT_STEP_LENGTH, DEFAULT_SPEED);
> 237: }
@alisenchung
Shouldn't `glide(Point src, Point dest)` and `glide(Point dest)` be retained in ExtendedRobot
In [previous comment](https://github.com/openjdk/jdk/pull/22044/files#r2085671341) it was mentioned that these methods won't be migrated so do they need to be retained in ExtendedRobot ?
I see `MultipleMouseButtonsTest.java` using `glide(Point src, Point dest)`. There are two options here:
1) Either update the test to use Robot's glide()
change the line `robot.glide(origin, center)` to `robot.glide(origin.x, origin.y, center.x, center.y);` and completely remove ExtendedRobot versions of glide.
2) Or retain these two convenience methods in ExtendedRobot.
-------------
PR Review: https://git.openjdk.org/jdk/pull/22044#pullrequestreview-2918163191
PR Review Comment: https://git.openjdk.org/jdk/pull/22044#discussion_r2140751723
More information about the client-libs-dev
mailing list