RFR: 8055461: getNextID in ImageIcon class can lead to overflow [v2]

[Alexey Ivanov]

On Fri, 13 Jun 2025 05:03:46 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> But if the fix doesnt hamper anything and still fixes the problem of overflow

The fix makes the code more complicated for no reason because… in your own words

> …**overflow itself doesn't apparently cause any issue**

> but I get popular sentiment of not fixing what ain't broke (or not proven yet to be broken)

Exactly! If it ain't broken and it works, don't fix it.

> maybe we should consider it..

We *may* consider it… Let's see if anyone else has an opinion.

Yet I'm strongly inclined to *not touching it* because **it works as expected** even when `IconImage.mediaTrackerId` overflows from positive into negative values and then back to positive values. (There's nothing wrong with a negative id.)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25666#issuecomment-2969834510