RFR: 8159055: ImageIcon.setImage can't handle null parameter [v4]

Prasanta Sadhukhan psadhukhan at openjdk.org
Mon Jun 16 14:59:13 UTC 2025


On Mon, 16 Jun 2025 14:14:05 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   javadoc
>
> test/jdk/javax/swing/ImageIcon/ImageIconNullImageTest.java line 40:
> 
>> 38:             ImageIcon icon = new ImageIcon();
>> 39:             icon.setImage(null);
>> 40:         });
> 
> `invokeAndWait` isn't needed here, you can run the test code on the main thread.
> 
> A comment that no NPE is expected would be good to clarify what the test expects.

ok

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25767#discussion_r2150226985


More information about the client-libs-dev mailing list