RFR: 8159055: ImageIcon.setImage can't handle null parameter [v8]

Abhishek Kumar abhiscxk at openjdk.org
Tue Jun 17 05:47:34 UTC 2025


On Mon, 16 Jun 2025 15:43:47 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> When trying to call 'icon.setImage(null);' where 'icon' is an instance of ImageIcon, a null pointer exception is thrown at runtime.
>> The code tried to get the `id` for that image and instantiates `MediaTracker` to associate the null image to that `id` and checks the status of loading this null image, removes the null image from the tracker and then tries to get the image width where it throws NPE as image is null.
>> 
>> It's better to not go through all MediaTracker usage and bail out initially itself for null image..
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix

test/jdk/javax/swing/ImageIcon/ImageIconNullImageTest.java line 27:

> 25:  * @test
> 26:  * @bug 8159055
> 27:  * @summary Verifies ImageIcon.setImage handles null parameter

Does it need to modify the summary as well ?

Apart from setImage method, null parameter is handled in constructor also.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25767#discussion_r2151368759


More information about the client-libs-dev mailing list